fix(sqlserver): support verify-full TLS mode - #443
Merged
tianzhou merged 2 commits intoOct 2, 2026
Merged
Conversation
Enable certificate and hostname verification when sslmode=verify-full is explicit. Accept the mode in TOML, document Node trust configuration, and add focused parser and configuration tests. Preserve existing defaults and parsing behavior.
Member
|
Please open an issue first |
Contributor
Author
|
Thanks. I opened #446 to describe the request. |
Contributor
Author
|
Fixed copilot findings. The SQL Server parser now rejects unsupported, empty, malformed, and duplicate sslmode values before connection setup. Added parser and TOML regression tests. Existing defaults and valid modes remain unchanged. |
Contributor
Author
|
While checking this PR, I found that the shared TOML loader can replace an empty sslmode with the DSN value before validation. This also affects other database engines, so I addressed it separately in #451. |
tianzhou
approved these changes
Oct 2, 2026
tianzhou
left a comment
tianzhou
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
sslmode=verify-fullsupport for SQL Server.verify-fullin TOML configuration.sslmodevalues.Tests
Add unit tests for:
verify-fulldriver options and TOML configuration.Additionally, a separate fix for empty TOML
sslmodevalues is proposed in #451.